Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop connections that didn't recently reply to a PING. #196

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mornfall
Copy link

PS: Did not even test-compile, much less test. If there's an easy way to get a
build of a PR out of OBS, I can try that way. Would need to switch the
libcommuni submodule somehow to the corresponding branch, did not yet figure
out how to do that.

@Thaodan Thaodan marked this pull request as draft August 7, 2022 06:58
@@ -148,6 +148,8 @@ void BufferProxyModel::addConnection(IrcConnection* connection)

void BufferProxyModel::insertConnection(int index, IrcConnection* connection)
{
connection->network()->setRequestedCapabilities(Irc::supportedCapabilities());

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check why this wasn't done before.

@mornfall mornfall closed this Aug 7, 2022
@Thaodan Thaodan reopened this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants